On Tue Feb 6 15:51:32 2024 +0000, Paul Gofman wrote:
I checked with _localtime64_s() on ucrtbase and it doesn't allow negative values. Maximum time is current _MAX__TIME64_T + 1555200 (vs 1605600 for _gmtime64_s), which is 14 hours difference and doesn't match neither negative offset of _gmtime64_s nor my local time difference to GMT (either side). So do you suggest updating _MAX__TIME64_T constant universally, for all the functions and CRT versions? Maybe we should keep old msvcrt result at least, and then drop test for CRT140 and follow up to date ucrtbase _gmtime64_s value?
That's a shame, I was hoping that there will be correlation between maximum values. I'm OK with current patch in this case.