On Thu Mar 7 18:58:35 2024 +0000, Zebediah Figura wrote:
2/6 seems to have a stray FIXME in it. I think 5/6 and 6/6 are fine but per discussion we may want them to be earlier lowering passes anyway? Note also you'll need to manually accept this one since it has my commits in it.
+% The main objective of this test is to see if operations for SM1
vertex shaders work.
+% Because they have a different instruction set that pixel shaders.
Dependent clauses should be separated by a comma, and "that" seems to be a typographical error.
It makes sense to implement 5/6 and 6/6 in ir.c, in the same spirit as instruction_array_lower_texkills(). I will work on doing that but in the mean time I fixed the other details.