On Fri Aug 22 10:27:34 2025 +0000, Huw Davies wrote:
Generally looks good, thanks! However, could you reword the commit message to be something like: `winealsa: Send All Notes Off and Reset Controllers.` ? Also, could you update the similar code in `winecoreaudio.drv/coremidi.c`? There, we already send 0x7b first, so it's just a question of replacing the 0x40 with a 0x79 and updating the comment. This change can go as a second commit in this same MR. I appreciate that you probably can't compile on macOS, but the CI will catch any errors in this trivial change.
Similar process exists not only in Core Audio but also in OSS, so I fixed that as well.