Re: [PATCH 0/4] MR1046: MfMediaEngine audio and invalid format fix.

[Stefan Dösinger (＠stefan)]

Stefan Dösinger (@stefan) commented about dlls/mfmediaengine/tests/mfmediaengine.c:
> -
>    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
> -
>    hr = IMFAttributes_SetUnknown(attributes, &MF_MEDIA_ENGINE_DXGI_MANAGER, (IUnknown *)manager);
> -
>    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
>
> }
>
> hr = IMFAttributes_SetUnknown(attributes, &MF_MEDIA_ENGINE_CALLBACK, (IUnknown *)callback);
> ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> - hr = IMFAttributes_SetUINT32(attributes, &MF_MEDIA_ENGINE_VIDEO_OUTPUT_FORMAT, DXGI_FORMAT_UNKNOWN);
> - ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
> - if (output_format)
> - {
> -
>    hr = IMFAttributes_SetUINT32(attributes, &MF_MEDIA_ENGINE_VIDEO_OUTPUT_FORMAT, output_format);
> -
>    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> - }

Is the if check necessary here? Before this patch MF_MEDIA_ENGINE_VIDEO_OUTPUT_FORMAT=DXGI_FORMAT_UNKNOWN was called all the time. It feels like this patch should keep calling it.