[PATCH v6 1/2] user32/tests: Check that message-only windows ignore WS_EX_TOPMOST.

[Giovanni Mascellani]

From: Giovanni Mascellani

libOVR brings a message window topmost claiming that this way it receives
WM_DEVICECHANGE faster. Currently, in Wine, this causes a WM_KILLFOCUS to
be sent to the actual topmost window, which in turn causes "Shantae: Risky's
Revenge" to minimize. The effect is that the game automatically minimizes
as soon as it is launched, which is incorrect.

Signed-off-by: Giovanni Mascellani 
---
 dlls/user32/tests/win.c | 92 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)

diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c
index 4c2af09d0c6..2f0a2b5ffb3 100644
--- a/dlls/user32/tests/win.c
+++ b/dlls/user32/tests/win.c
@@ -8898,6 +8898,97 @@ static void test_hwnd_message(void)
     DestroyWindow(hwnd);
 }

+static HWND message_window_topmost_hwnd_msg = NULL;
+
+static LRESULT WINAPI message_window_topmost_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
+{
+    if (message_window_topmost_hwnd_msg)
+    {
+        /* On Windows no message at all is expected here. However that
+         * would be brittle on Wine, because asynchronous X11 events
+         * could arrive at any time for the regular window. To balance
+         * between sensibility and specificity, WM_KILLFOCUS is always
+         * considered bad, while all the other messages are considered
+         * bad only on the message-only widow. */
+        todo_wine_if(msg == WM_KILLFOCUS)
+        ok(msg != WM_KILLFOCUS, "Received message WM_KILLFOCUS for window %p (message-only window is %p)\n",
+                hwnd, message_window_topmost_hwnd_msg);
+        todo_wine_if(hwnd == message_window_topmost_hwnd_msg)
+        ok(hwnd != message_window_topmost_hwnd_msg, "Received message %u for message-only window %p\n",
+                msg, hwnd);
+    }
+
+    return DefWindowProcW(hwnd, msg, wparam, lparam);
+}
+
+static void test_message_window_topmost(void)
+{
+    WNDCLASSW cls = { 0 };
+    HWND hwnd, hwnd_msg;
+    HDWP hdwp;
+    ATOM atom;
+    BOOL ret;
+    MSG msg;
+
+    cls.lpfnWndProc = message_window_topmost_proc;
+    cls.hInstance = GetModuleHandleW(NULL);
+    cls.lpszClassName = L"test_message_window_topmost";
+    atom = RegisterClassW(&cls);
+    ok(!!atom, "Cannot register window class\n");
+
+    hwnd = CreateWindowW(L"test_message_window_topmost", L"main window", WS_OVERLAPPEDWINDOW | WS_VISIBLE,
+            CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, NULL, NULL, GetModuleHandleW(NULL), NULL);
+    ok(!!hwnd, "Cannot create main window\n");
+
+    hwnd_msg = CreateWindowW(L"test_message_window_topmost", L"message window", 0,
+            CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, HWND_MESSAGE, NULL, GetModuleHandleW(NULL), NULL);
+    ok(!!hwnd_msg, "Cannot create message window\n");
+
+    while (PeekMessageW(&msg, NULL, 0, 0, PM_REMOVE))
+    {
+        TranslateMessage(&msg);
+        DispatchMessageW(&msg);
+    }
+
+    message_window_topmost_hwnd_msg = hwnd_msg;
+
+    SetLastError(0xdeadbeef);
+
+    ret = SetWindowPos(hwnd_msg, HWND_TOPMOST, 100, 100, 100, 100, 0);
+    ok(ret, "Unexpected failure when calling SetWindowPos()\n");
+
+    ret = SetWindowPos(hwnd_msg, HWND_NOTOPMOST, 100, 100, 100, 100, 0);
+    ok(ret, "Unexpected failure when calling SetWindowPos()\n");
+
+    hdwp = BeginDeferWindowPos(2);
+    ok(!!hdwp, "Unexpected failure when calling BeginDeferWindowPos()\n");
+
+    hdwp = DeferWindowPos(hdwp, hwnd_msg, HWND_TOPMOST, 100, 100, 100, 100, 0);
+    ok(!!hdwp, "Unexpected failure when calling DeferWindowPos()\n");
+
+    hdwp = DeferWindowPos(hdwp, hwnd_msg, HWND_NOTOPMOST, 100, 100, 100, 100, 0);
+    ok(!!hdwp, "Unexpected failure when calling DeferWindowPos()\n");
+
+    ret = EndDeferWindowPos(hdwp);
+    ok(ret, "Unexpected failure when calling EndDeferWindowPos()\n");
+
+    todo_wine ok(GetLastError() == 0xdeadbeef, "Last error unexpectedly set to %#lx\n", GetLastError());
+
+    while (PeekMessageW(&msg, NULL, 0, 0, PM_REMOVE))
+    {
+        TranslateMessage(&msg);
+        DispatchMessageW(&msg);
+    }
+
+    message_window_topmost_hwnd_msg = NULL;
+
+    ok(DestroyWindow(hwnd_msg), "Cannot destroy main window\n");
+    ok(DestroyWindow(hwnd), "Cannot destroy message window\n");
+
+    ok(UnregisterClassW(L"test_message_window_topmost", GetModuleHandleW(NULL)), "Cannot unregister class\n");
+}
+
+
 static void test_layered_window(void)
 {
     HWND hwnd, child;
@@ -13088,6 +13179,7 @@ START_TEST(win)
     test_thick_child_size(hwndMain);
     test_fullscreen();
     test_hwnd_message();
+    test_message_window_topmost();
     test_nonclient_area(hwndMain);
     test_params();
     test_GetWindowModuleFileName();