Re: [PATCH 0/3] MR5190: dmime: MIDI tempotrack

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/tempotrack.c:
>      return DMUS_E_UNSUPPORTED_STREAM;
>
> - hr = stream_chunk_get_array(stream, &chunk, (void **)&This->items, &This->count,
> - hr = stream_chunk_get_array(stream, &chunk, (void **)&items, &count,
>         sizeof(DMUS_IO_TEMPO_ITEM));
> if (FAILED(hr))
>     return hr;
> - for (i = 0; i < This->count; i++) {
> -
>    TRACE_(dmfile)("DMUS_IO_TEMPO_ITEM #%u\n", i);
> -
>    TRACE_(dmfile)(" - lTime = %lu\n", This->items[i].lTime);
> -
>    TRACE_(dmfile)(" - dblTempo = %g\n", This->items[i].dblTempo);
> - for (i = 0; i < count; i++)
> - {
> -
>    struct tempo_entry *entry = calloc(1, sizeof(*entry));
> -
>    if (!entry) hr = E_OUTOFMEMORY;

You should break probably here, or add SUCCEEDED(hr) to the loop conditions.