17 Sep
2023
17 Sep
'23
1:52 a.m.
1. Yes, it is a lot of code, which most is required for proper patching to work. I'm not sure exactly sure how to split up the bulk of it. 2. Testing this is somewhat difficult since a patch file and associated "old" file would be needed to test the patch transformations. Could you provide a suggestion on how similar tests are conducted? 3. I did not re-order any functions, did you thoroughly study my changes? A lot of code was removed, not re-ordered. 4. FIXME stubs were replaced with warnings/traces except for the previous stubs. I.e.: https://gitlab.winehq.org/wine/wine/-/merge_requests/3870/diffs#acda5f5d040f...
I would appreciate some guidance and constructive advice rather than a list of things that are wrong with these changes :)