Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_muxer.c:
- GstCaps *src_caps = NULL;
- char src_pad_name[32];
- int ret;
- /* Create stream object. */
- if (!(stream = calloc(1, sizeof(*stream))))
return E_OUTOFMEMORY;
- stream->muxer = muxer;
- stream->format = *params->format;
- stream->id = params->stream_id;
- /* Create src pad. */
- if (!(src_caps = wg_format_to_caps(params->format)))
goto out;
- if (params->format->major_type == WG_MAJOR_TYPE_VIDEO_H264)
gst_caps_set_simple(src_caps, "stream-format", G_TYPE_STRING, "avc", NULL);
Does this belong here? Should it be in our `wg_format_to_caps` instead? I don't really know what these H264 "stream-format" / "alignment" meant, but I believe @bshanks said something about it on macOS (vtdec only accepting avc stream-format).