Re: [PATCH v2 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move get_application_name into mmdevapi.

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/mmdevapi/client.c:
> }
>
> +static BOOL query_productname(void *data, LANGANDCODEPAGE *lang, LPVOID *buffer, UINT *len)
> +{
> - WCHAR pn[37];
> - swprintf(pn, ARRAY_SIZE(pn), L"\StringFileInfo\%04x%04x\ProductName", lang->wLanguage, lang->wCodePage);
> - return VerQueryValueW(data, pn, buffer, len) && *len;
>
> +}
> -
>
> +WCHAR *get_application_name(void)
> +{
> - WCHAR path[MAX_PATH], *name;
> - UINT translate_size, productname_size;
> - LANGANDCODEPAGE *translate;
> - LPVOID productname;
> - BOOLEAN found = FALSE;

Could we avoid making unnecessary changes like `BOOL` -> `BOOLEAN`?  It makes looking for real changes using e.g. `--color-moved` more difficult.