6 Jul
2023
6 Jul
'23
7:58 a.m.
On Thu Jul 6 04:32:40 2023 +0000, Kurt Kartaltepe wrote:
Getting back to this, compilers seem not to complain about interchange of enum/bool/uint types. I've made all of the struct fields use the sized uint types and not added any helpers for now to minimize the changes. If you think we really should have conversion helpers I can add them in. It seems there are also a few places elsewhere wine uses enums in the wow64 thunks if you want to fix them up later
mmdevapi/unixlib.h - test_connect_params.priority msv1_0/unixlib.h - chat_params.ntlm_ctx.mode secur32/secur32_priv.h - handshake_params.control_token
Looks okay to me, with a nitpick that I'd rather use uint8_t / UINT8 directly instead of introducing a custom BOOL8 type. Thanks for looking for the enum uses.
Please also squash the fixups into the main commit.