29 Jan
2024
29 Jan
'24
7:08 p.m.
On Mon Jan 29 19:06:32 2024 +0000, Rémi Bernon wrote:
changed this line in [version 13 of the diff](/wine/wine/-/merge_requests/3103/diffs?diff_id=96513&start_sha=02f3db777425418f9a5da96713d355027b7e6bbd#65b3cab82e46519733db1b5e9ec0bae066630154_252_252)
Actually I think instead it should be removed. As I understand it the code in wineserver explicitly avoids clearing memory if not necessary, though I don't know if that's for efficiency or to avoid implicit initialization.
As we're mmapping new pages now it should be zeroed already and this was unnecessary. It was more like a leftover from a time where the code allowed mappings to be reused somehow.