Re: [PATCH 0/1] MR3185: bcrypt: Add RC4 algorithm stub.

[Vladislav Timonin (＠vt)]

Vladislav Timonin (@vt) commented about dlls/bcrypt/bcrypt_main.c:
>  return STATUS_NOT_IMPLEMENTED;
>
> }
>
> +static NTSTATUS get_rc4_property( enum chain_mode mode, const WCHAR *prop, UCHAR *buf, ULONG size, ULONG *ret_size )
> +{
> - if (!wcscmp( prop, BCRYPT_BLOCK_LENGTH ))
> - {
> -
>    *ret_size = sizeof(ULONG);
> -
>    if (size < sizeof(ULONG)) return STATUS_BUFFER_TOO_SMALL;
> -
>    if (buf) *(ULONG *)buf = BLOCK_LENGTH_RC4;
> -
>    return STATUS_SUCCESS;
> - }
> -

Should probably implement `BCRYPT_CHAINING_MODE` getter as well, since there's a setter. Seeing how setting anything other than `BCRYPT_CHAIN_MODE_NA` returns `STATUS_NOT_SUPPORTED`, guessing it always returns `BCRYPT_CHAIN_MODE_NA`.