On Mon Aug 12 12:16:17 2024 +0000, Rémi Bernon wrote:
Is the check for `wayland_surface` necessary? How can a window with a parent be a top-level window?
This is just to guard against the (unlikely) case of some `parent_data->wayland_surface` creation failure which would lead to a crash further down this function. The fallback to become toplevel was just convenient due to the if statement, but I can change it to fall back to NONE role instead.