20 Mar
2023
20 Mar
'23
3:53 p.m.
On Mon Mar 20 15:53:23 2023 +0000, Henri Verbeet wrote:
+static void read_int(const char **line, int *ptr)I think "ptr" is a bit of an awkward name for this. Likewise for read_uint().
+static void read_int4(const char **line, int (*v)[4])The "natural" type for "v" would seem struct ivec4. I imagine the choice of passing an array was largely dictated by the set_uniforms() interface, but perhaps it shouldn't be? Likewise for read_uint4().
Fixed. I guess we already assume that `struct ivec4` and `struct uvec4` will always be packed, right? More or less as we already assumed that `int[4]` is packed.