On Tue Apr 2 23:00:25 2024 +0000, Rémi Bernon wrote:
len = strlen( buf );
Fwiw IMO the strcat would be worth replacing with `snprintf` too, and the buffer size here feels a bit short, i don't see an easy way to make it 100% safe but maybe making it larger would be better.
Yeah, makes sense to use snprintf consistently. A large `Text` field could fill up the buffer, but it's being passed to `wine_dbg_sprintf` which only looks to have a 200-byte buffer itself. An alternative would be to TRACE directly instead of writing to a buffer (like `trace_devmode`), but I don't think that's necessary. Menu items usually have short names.