Re: [PATCH v5 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.

[Bernhard Kölbl (＠besentv)]

Bernhard Kölbl (@besentv) commented about dlls/windows.media/main.c:
> +#include "private.h"
> -
>
> +#include "wine/debug.h"
> -
>
> +WINE_DEFAULT_DEBUG_CHANNEL(media);
> -
>
> +HRESULT WINAPI DllGetClassObject(REFCLSID clsid, REFIID riid, void **out)
> +{
> - FIXME( "(clsid %s, riid %s, out %p) - stub.\n", debugstr_guid(clsid), debugstr_guid(riid), out );
> - return CLASS_E_CLASSNOTAVAILABLE;
>
> +}
> -
>
> +HRESULT WINAPI DllGetActivationFactory(HSTRING classid, IActivationFactory **factory)
> +{
> - FIXME( "(class %s, factory %p.) - stub.\n", debugstr_hstring(classid), factory );
> - *factory = NULL;

You should add a query interface for your statics class (IID_IActivationFactory) here, else it's dead code. Look in Windows.Gaming.Input how it's done.