On Tue May 23 16:24:16 2023 +0000, Jinoh Kang wrote:
uiautomationcore: Add support for advising providers of events being added/removed.
[Advice] means code that is inserted at certain points to modify behavior of functions (similar to hooks). I suggest keeping the vocabulary consistent with https://learn.microsoft.com/en-us/windows/win32/api/uiautomationcore/nn-uiau...:
uiautomationcore: Add support for *notifying* providers of events
being added/removed. [Advice]: https://en.wikipedia.org/wiki/Advice_(programming)
I'd generally agree, but the interface is called `IRawElementProviderAdviseEvents`, and the methods are called `AdviseEventAdded` and `AdviseEventRemoved`. IMO, introducing the word 'notify' could add confusion, given someone might start looking for 'notify' or 'notifier' in the code.
I'm a bit split on that. I definitely like the word notify better than advise, but it does introduce a split between the interface name/method names and our code potentially.