Re: [PATCH v2 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)

[Joel Holdsworth (＠jhol)]

Joel Holdsworth (@jhol) commented about dlls/ntdll/unix/file.c:
> }
>
> +/* decode the xattr-stored DOS attributes */
> +static int parse_samba_dos_attrib_data( char *data, int len )
> +{
> - size_t string_len = strnlen( data, len );
> -
> - if (len > string_len + 3)
> - {
> -
>    uint16_t version;
> -
>    memcpy( &version, data + string_len + 1, 2 );
>
> +#ifndef WORDS_BIGENDIAN
> -
>    version = (version >> 8) | (version << 8);
>
> +#endif

Ideally this would be done with `ntohs`, but I'm not sure there is a good way to pull it in here without causing chaos. We could `#include <winsock2.h>`, but that seems to conflict with `<sys/socket.h>` and friends.