Re: [PATCH 0/1] MR4794: comctl32/combo: Add tests for keypresses showing search functionality

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/comctl32/tests/combo.c:
> - }
> -
> - SendMessageA(combo, WM_CHAR, (WPARAM)'a', 0);
> - get_selected_value(combo, selected);
> - todo_wine_if(sort)
> - ok(!strcmp(selected, results[0][0]), "sort %d - Got %s\n", sort, selected);
> -
> - SendMessageA(combo, WM_CHAR, (WPARAM)'l', 0);
> - get_selected_value(combo, selected);
> - todo_wine_if(sort)
> - ok(!strcmp(selected, results[0][1]), "sort %d - Got %s\n", sort, selected);
> -
> - SendMessageA(combo, WM_CHAR, (WPARAM)'p', 0);
> - get_selected_value(combo, selected);
> - todo_wine_if(sort)
> - ok(!strcmp(selected, results[0][2]), "sort %d - Got %s\n", sort, selected);

It would be more readable to have some strings here explicitly tested, without [x][y] on some array.