On Fri Nov 18 22:50:46 2022 +0000, Bartosz Kosiorek wrote:
@madewokherd Generally feel free to improve/fix/change this code. I am novice in Wine development, and I am still learning. Some help from your side would be much appreciated. I am a little bit scaird that the Merge Request become quite big and hard to understand.
Yeah, this might need to be broken into smaller MRs.
The questions I generally ask in a situation like this one, where we know it's not quite right yet are: How hard is it to implement correctly? And will taking the shortcut make it more difficult to implement correctly without causing regressions?
I don't think it should be too difficult to create a pen object and pass it to GdipWidenPath, nor will taking the shortcut make it harder to fix later. With that in mind, I would be willing to settle for this, but it'd be good to have a comment or fixme so we know the current approach isn't right.
We might find that the outline codepath is rarely-used to begin with and never bother.