Re: [PATCH 0/4] MR7386: d3dx9: Add support for saving surfaces to targa files.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
>  }
>
> }
>
> +static BOOL is_dxt_d3dformat(D3DFORMAT fmt)
> +{
> - return (fmt & 0x00ffffff) == MAKEFOURCC('D','X','T',0);
>
> +}
> -
>
> +static void test_save_surface_iffs(IDirect3DDevice9 *device)
> +{
> - static const D3DXIMAGE_FILEFORMAT test_iff[] = { D3DXIFF_BMP, D3DXIFF_JPG, D3DXIFF_TGA, D3DXIFF_PNG,
> -
>                                                 D3DXIFF_PPM, D3DXIFF_DIB, D3DXIFF_HDR, D3DXIFF_PFM };
> - static const char *test_iff_str[] = { "D3DXIFF_BMP", "D3DXIFF_JPG", "D3DXIFF_TGA", "D3DXIFF_PNG",
> -
>                                      "D3DXIFF_PPM", "D3DXIFF_DIB", "D3DXIFF_HDR", "D3DXIFF_PFM" };

It might be nicer to have that together as an array of structures:
```suggestion:-3+0
    static const struct
    {
        D3DXIMAGE_FILEFORMAT format;
        const char *name;
    }
    test_iffs[] =
    {
        {D3DXIFF_BMP, "D3DXIFF_BMP"},
        {D3DXIFF_JPG, "D3DXIFF_JPG"},
        ...
```