On Thu Aug 22 17:26:34 2024 +0000, Paul Gofman wrote:
Is there a reason to retry on EACCES, instead of just always setting
SO_BROADCAST before calling connect()? Well, I didn't check thoroughly if it is going to break anything under presumption that it might and it is cleaner to avoid such tweaks on the default path. Also, it is an extra syscall in wineserver otherwise unneeded on the common path (and avoided in the current version of the patch), I'd expect the case when it will actually trigger to be very rare.
I'm not sure that either of those are really worth worrying about, but I can't say I have strong feelings about it either.