Re: [PATCH 0/3] MR749: vkd3d-shader/ir: Minimise temp usage.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/ir.c:
> -
>        reg->idx[0].offset = i;
> -
>    }
> -
>    else
> -
>    {
> -
>        reg->idx[0].offset = ssa->table[reg->idx[0].offset] - 1;
> -
>    }
>
> }
>
> for (i = 0; i < reg->idx_count; ++i)
>        if (reg->idx[i].rel_addr)
> -
>        materialize_ssas_to_temps_process_src_param(program, reg->idx[i].rel_addr);
> -
>        materialize_ssas_to_temps_process_src_param(program, ssa, reg->idx[i].rel_addr);
>
> }
>
> -static void materialize_ssas_to_temps_process_dst_param(struct vsir_program *program,
> +static void materialize_ssas_to_temps_process_dst_param(struct vsir_program *program, struct ssa_allocation *ssa,

For the record, I am not particularly attached to these two helpers. I introduced them at some point when I believed that something specific for source and destination parameters had to be done, but they look pretty useless now. If you want to take advantage of the churn to remove them along, no objections on my side.