On Mon Mar 3 20:21:47 2025 +0000, Hans Leidekker wrote:
Commit 9015eebf87e3de8f9c541299e529c9667cc4847b caused a regression which is fixed by e7ff2688c8042fb6d7af163480b1d2ec849d0dee.
Thanks for notifying me, my scripts had no chance of finding the regression as there's no bug for it nor a reference to the commit introducing the regression.
Now there is an issue with e7ff2688 as it depends on RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO introduced with 0b441c4c8ff9 / MR!5071. @gofman I'm assuming I can pull in 0b441c4c8ff9 that defines RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO and then e7ff2688 which uses it. I mean without producing any adverse effect. The critical section will have that flag set but nothing will make use of it and more importantly not barf when it sees that.
The alternative is to just drop 9015eebf if this produces too much hassle.