Esme Povirk (@madewokherd) commented about dlls/windowscodecs/metadatahandler.c:
}
static HRESULT WINAPI MetadataHandler_SetValue(IWICMetadataWriter *iface,
- const PROPVARIANT *pvarSchema, const PROPVARIANT *pvarId, const PROPVARIANT *pvarValue)
const PROPVARIANT *schema, const PROPVARIANT *id, const PROPVARIANT *value)
{
- FIXME("(%p,%p,%p,%p): stub\n", iface, pvarSchema, pvarId, pvarValue);
- return E_NOTIMPL;
- MetadataHandler *This = impl_from_IWICMetadataWriter(iface);
- MetadataItem *item, *new_items;
- HRESULT hr;
- TRACE("(%p,%p,%p,%p)\n", iface, schema, id, value);
- if (!value)
Is there a reason we don't check for NULL id here?