Re: [PATCH 6/6] wmvcore/tests: Test async reader DedicatedDeliveryThread setting.

[Zebediah Figura]

On 8/20/22 09:02, Rémi Bernon wrote:
> -
> -
>
> trace("Checking default settings.\n");
> -
>
> trace("  with stream selection\n");
> -
>
> test_async_reader_selection(reader, advanced, &callback);
> -
>
> trace("  with sample allocation\n");
> -
>
> test_async_reader_allocate(reader, advanced, &callback);
> -
>
> trace("  with compressed sample\n");
> -
>
> test_async_reader_compressed(reader, advanced, &callback);
> -
>
> trace("  with compressed sample allocation\n");
> -
>
> test_async_reader_allocate_compressed(reader, advanced, &callback);
> -
> -
>
> callback.dedicated_threads = TRUE;
> -
>
> trace("Checking DedicatedDeliveryThread.\n");
> -
>
> trace("  with stream selection\n");
>  test_async_reader_selection(reader, advanced, &callback);
> -
>
> trace("  with sample allocation\n");
>  test_async_reader_allocate(reader, advanced, &callback);
> -
>
> trace("  with compressed sample\n");
>  test_async_reader_compressed(reader, advanced, &callback);
> -
>
> trace("  with compressed sample allocation\n");
>  test_async_reader_allocate_compressed(reader, advanced, &callback);
> -
>
> callback.dedicated_threads = FALSE;
>
> hr = IWMReader_Close(reader);
>  ok(hr == S_OK, "Got hr %#lx.\n", hr);

It'd be best to avoid these traces, at least with the default debug 
level. Probably winetest_push_context() would be best here.

We could probably also put the 4 streaming tests into a helper function, 
especially if you're adding a bunch of traces.