On Thu Mar 21 11:23:26 2024 +0000, Jacek Caban wrote:
IMHO this nicely summaries why the macro is ugly (and an explicit loop that I suggested earlier would make it much more obvious in client code).
@rbernon said on this matter "I personally like that it looks like server requests, it makes wineserver communication stand out compared to other function calls."
I don't have strong opinions either way. Even if we *do* get rid of the macro, though, I'd propose that we keep this documentation no matter what since people can write bad code (emphasis on the "conditional" part).
*Personally* I'd go even further and just have a function that does everything: receive field offsets, and have an internal loop that fills out the out pointers (so that the user doesn't have to write the loop).