Re: [PATCH v6 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux

[Tomas-Mendes-ai (＠Tomas-Mendes-ai)]

Tomas-Mendes-ai (@Tomas-Mendes-ai) commented about dlls/ntdll/unix/system.c:
> -
>        int energy_full_uwh;
> -
>        int energy_now_uwh;
> -
>        int power_now_uw;
> -
>    } energy;
> -
>    struct {
> -
>        int charge_full_uah;
> -
>        int charge_now_uah;
> -
>        int current_now_ua;
> -
>    } charge;
> - } capacity;
> -
> - int voltage_now;
> - int alarm;
> - int capacity_alert_min;
> - int capacity_alert_max;
>
> +};

Should this be defined inside the #ifdef linux block where it's implemented?

As it stands, that would avoid leaking Linux-specific code to other platforms. But I’m not sure if it would make sense, now or later, to abstract this for reuse on other platforms and avoid duplicating logic.