On Thu Nov 2 13:26:14 2023 +0000, Giovanni Mascellani wrote:
Not really important, but it doesn't look like you need to create three variables for these. Just inline the call to `sm4_get_index_addressing_from_reg()` below.
While you're at it I'd advocate for moving the range check to the caller; I think it's clearer what its purpose is there.