Re: [PATCH v6 0/2] MR9351: msvcrt: Correctly handle refcounts for WinRT exceptions

[Vibhav Pant (＠vibhavp)]

Vibhav Pant (@vibhavp) commented about dlls/ucrtbase/tests/cpp.c:
> +};
> -
>
> +static IUnknown iunknown_except2 = { &iunknown_except2_vtbl };
> -
>
> +static LONG WINAPI filter(struct _EXCEPTION_POINTERS *ep, void *frame)
> +{
> - CHECK_EXPECT(filter);
> -
> - ok(frame == (void*)0x1234, "frame = %p\n", (void*)frame);
> - SET_EXPECT(iunknown_except_Release);
> - return EXCEPTION_EXECUTE_HANDLER;
>
> +}
> -
>
> +static void test___C_specific_handler(void)
> +{
> - struct

It might be too complicated, but would it be worth it to also have similar tests for non-TYPE_FLAG_WINRT classes to make sure ucrtbase does this for all C++ classes? Something like a destructor function `dtor`, using `cxx_exception_type` for `info`,  and setting info->destructor to `dtor - ImageBase`.