On Fri Apr 26 15:52:42 2024 +0000, Gabriel Ivăncescu wrote:
OK, I see what you mean with the IID. I didn't think of it, because I thought of delegating everything to mshtml (which already queries the IID and returns appropriate error) and making a generic interface for jscript so that it won't care of also checking it, but if you're ok with that I can try to squash the interfaces. For the lookup, we need name-based lookup unfortunately because that's the whole point of the fixup (and override): such props may not have existed before, so what would the ID even be? That said, I'm not sure either of these have to do with this MR, I mean "prop_fixup" itself is not tied to the fixup on the mshtml side (which can have a different interface later), but it's for jscript code itself. Anything in particular wrong with the interfaces in this MR? Or something you'd rather have done differently? Even if we change PropFixup to PropGetInfo, I don't think it will change the jscript side for this MR.
I pushed new version to `jscript-proxies` that should address the suggestions. But it didn't change anything in the jscript object vtbl (for props I mean, not those interacting with mshtml). So for this MR, nothing changed at all.