Re: [PATCH 0/5] MR2741: sapi: Implement more ISpObjectToken functionality.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about dlls/sapi/token.c:
> static HRESULT WINAPI data_key_SetStringValue( ISpRegDataKey *iface,
>                                                 LPCWSTR name, LPCWSTR value )
>  {
> - FIXME( "stub\n" );
> - return E_NOTIMPL;
> - struct data_key *This = impl_from_ISpRegDataKey( iface );
> - DWORD ret, size;
> -
> - TRACE( "%p, %s, %s\n", This, debugstr_w(name), debugstr_w(value) );
> -
> - if (!This->key)
> -
>    return E_HANDLE;
> -
> - size = (lstrlenW(value) + 1) * sizeof(WCHAR);
> - ret = RegSetValueExW( This->key, name, 0, REG_SZ, (BYTE *)value, size );

Apparently a data key can be set as read-only. Maybe this should be taken into account here (it shouldn't be too hard to test for that).