Re: [PATCH v4 0/8] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/ntdll/unix/virtual.c:
> -
>            FIXME( "Not supported requirements LowestStartingAddress %p, Alignment %p.\n",
> -
>                   r->LowestStartingAddress, (void *)r->Alignment );
> -
> -
>        if (r->Alignment)
> -
>        {
> -
>            if (*ret || (r->Alignment & (r->Alignment - 1)) || r->Alignment - 1 < granularity_mask)
> -
>            {
> -
>                WARN( "Invalid alignment %lu.\n", r->Alignment );
> -
>                return STATUS_INVALID_PARAMETER;
> -
>            }
> -
>            align = r->Alignment;
> -
>        }
> -
> -
>        limit = (ULONG_PTR)r->HighestEndingAddress;
> -
>        if (limit && (*ret || limit > (ULONG_PTR)user_space_limit || ((limit + 1) & (page_mask - 1))))
> -
>        {

This would most likely need to check against the user space limit of the target process.