Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm4.c:
if (var->is_uniform) {
if (data_type->class == HLSL_CLASS_OBJECT && data_type->base_type == HLSL_TYPE_TEXTURE)
enum hlsl_regset regset = HLSL_REGSET_NUMERIC;
if (hlsl_type_is_resource(data_type))
regset = hlsl_type_get_regset(data_type);
Why not directly `regset = hlsl_type_get_regset(data_type)`? Structures should never reach this point, should they?