Re: [PATCH v2 0/2] MR8874: cmd: Fix TYPE behavior.

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/cmd/builtins.c:
>  return NO_ERROR;
>
> }
>
> +/****************************************************************************
> -
> - WCMD_convert_text
> -
> -
> -
> - Converts bytes to wide characters in the specified code page.
> - */
>
> +static int WCMD_convert_text(UINT codepage, char *buffer, DWORD count, LPWSTR *outBuf)
> +{
> - int numChars;
> -
> - numChars = MultiByteToWideChar(codepage, 0, buffer, count, NULL, 0);
> - if (numChars) {
> - *outBuf = xalloc(numChars * sizeof(WCHAR));
> - if (*outBuf) {

xalloc terminates program in OOM conditions

so outBuf is always non NULL

please use the style for new code (4 spaces indent, curly braces on next line...)