[PATCH v6 2/4] ntdll: Implement storing DOS attributes in NtSetInformationFile.

[Erich E. Hoover]

From: "Erich E. Hoover"

Co-authored-by: Joel Holdsworth 
Signed-off-by: Joel Holdsworth 
---
 dlls/ntdll/unix/file.c | 111 +++++++++++++++++++++++++++++++++--------
 1 file changed, 91 insertions(+), 20 deletions(-)

diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c
index c38b3003059..2a0dda8b2c8 100644
--- a/dlls/ntdll/unix/file.c
+++ b/dlls/ntdll/unix/file.c
@@ -362,6 +362,36 @@ NTSTATUS errno_to_status( int err )
 }

+static int xattr_fremove( int filedes, const char *name )
+{
+#if defined(HAVE_SYS_XATTR_H)
+#if defined(XATTR_ADDITIONAL_OPTIONS)
+    return fremovexattr( filedes, name, 0 );
+#else
+    return fremovexattr( filedes, name );
+#endif
+#else
+    errno = ENOSYS;
+    return -1;
+#endif
+}
+
+
+static int xattr_fset( int filedes, const char *name, void *value, size_t size )
+{
+#if defined(HAVE_SYS_XATTR_H)
+#if defined(XATTR_ADDITIONAL_OPTIONS)
+    return fsetxattr( filedes, name, value, size, 0, 0 );
+#else
+    return fsetxattr( filedes, name, value, size, 0 );
+#endif
+#else
+    errno = ENOSYS;
+    return -1;
+#endif
+}
+
+
 static int xattr_get( const char *path, const char *name, void *value, size_t size )
 {
 #if defined(HAVE_SYS_XATTR_H)
@@ -1509,6 +1539,66 @@ static int fd_get_file_info( int fd, unsigned int options, struct stat *st, ULON
 }

+static int fd_set_dos_attrib( int fd, ULONG attr )
+{
+    /* do not store everything, but keep everything Samba can use */
+    attr &= ~FILE_ATTRIBUTE_NORMAL;
+    if (attr != 0)
+    {
+        char hexattr[11];
+        int len = sprintf( hexattr, "0x%x", attr );
+        int ret;
+        struct stat st;
+
+        ret = xattr_fset( fd, SAMBA_XATTR_DOS_ATTRIB, hexattr, len );
+        if (ret == 0) return 0;
+        if (errno != EACCES) return ret;
+
+        /* if we don't have access, try temporarily modifying permissions. */
+        if (fstat( fd, &st ) != 0 ||
+            st.st_uid != getuid() ||
+            fchmod( fd, st.st_mode | S_IRUSR ) != 0)
+        {
+            errno = EACCES;
+            return -1;
+        }
+
+        ret = xattr_fset( fd, SAMBA_XATTR_DOS_ATTRIB, hexattr, len );
+        if (ret != 0) return ret;
+
+        return fchmod( fd, st.st_mode );
+    }
+    else
+        return xattr_fremove( fd, SAMBA_XATTR_DOS_ATTRIB );
+}
+
+
+/* set the stat info and file attributes for a file (by file descriptor) */
+NTSTATUS fd_set_file_info( int fd, ULONG attr )
+{
+    struct stat st;
+
+    if (fstat( fd, &st ) == -1) return errno_to_status( errno );
+    if (attr & FILE_ATTRIBUTE_READONLY)
+    {
+        if (S_ISDIR( st.st_mode))
+            WARN("FILE_ATTRIBUTE_READONLY ignored for directory.\n");
+        else
+            st.st_mode &= ~0222; /* clear write permission bits */
+    }
+    else
+    {
+        /* add write permission only where we already have read permission */
+        st.st_mode |= (0600 | ((st.st_mode & 044) >> 1)) & (~start_umask);
+    }
+    if (fchmod( fd, st.st_mode ) == -1) return errno_to_status( errno );
+
+    fd_set_dos_attrib( fd, attr );
+
+    return STATUS_SUCCESS;
+}
+
+
 /* get the stat info and file attributes for a file (by name) */
 static int get_file_info( const char *path, struct stat *st, ULONG *attr )
 {
@@ -4403,7 +4493,6 @@ NTSTATUS WINAPI NtSetInformationFile( HANDLE handle, IO_STATUS_BLOCK *io,
     case FileBasicInformation:
         if (len >= sizeof(FILE_BASIC_INFORMATION))
         {
-            struct stat st;
             const FILE_BASIC_INFORMATION *info = ptr;
             LARGE_INTEGER mtime, atime;

@@ -4417,25 +4506,7 @@ NTSTATUS WINAPI NtSetInformationFile( HANDLE handle, IO_STATUS_BLOCK *io,
                 status = set_file_times( fd, &mtime, &atime );

if (status == STATUS_SUCCESS && info->FileAttributes)
-            {
-                if (fstat( fd, &st ) == -1) status = errno_to_status( errno );
-                else
-                {
-                    if (info->FileAttributes & FILE_ATTRIBUTE_READONLY)
-                    {
-                        if (S_ISDIR( st.st_mode))
-                            WARN("FILE_ATTRIBUTE_READONLY ignored for directory.\n");
-                        else
-                            st.st_mode &= ~0222; /* clear write permission bits */
-                    }
-                    else
-                    {
-                        /* add write permission only where we already have read permission */
-                        st.st_mode |= (0600 | ((st.st_mode & 044) >> 1)) & (~start_umask);
-                    }
-                    if (fchmod( fd, st.st_mode ) == -1) status = errno_to_status( errno );
-                }
-            }
+                status = fd_set_file_info( fd, info->FileAttributes );

if (needs_close) close( fd );
         }