26 Nov
2024
26 Nov
'24
8:14 a.m.
On Tue Nov 26 07:03:25 2024 +0000, Aida Jonikienė wrote:
The tests should probably be split to a separate commit (and also Wine follows the `<component>: <short message>.` commit message format with an optional description at the bottom; so something like `ntdll: Frog.`)
on top of Aida's comments:
* don't use // comments * [1] show that (as you said) Windows behavior changed, so early (Win7) windows versions show failures. This should be marked with the `broken() `macro in the tests (all tests must pass on all platforms) * less importantly, [1] also shows some trailing whitespaces in the MR