[PATCH v3 2/7] mfplat/tests: Introduce a helper to check the platform lock count.

[Conor McCarthy]

From: Conor McCarthy

---
 dlls/mfplat/tests/mfplat.c | 63 ++++++++++++++++++++++++++++----------
 1 file changed, 47 insertions(+), 16 deletions(-)

diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c
index 203defec77a..9539646d6ab 100644
--- a/dlls/mfplat/tests/mfplat.c
+++ b/dlls/mfplat/tests/mfplat.c
@@ -219,6 +219,37 @@ static void check_attributes_(const char *file, int line, IMFAttributes *attribu
     }
 }

+#define check_platform_lock_count(a) check_platform_lock_count_(__LINE__, a, FALSE)
+#define check_and_clear_platform_lock_count(a) check_platform_lock_count_(__LINE__, a, TRUE)
+static void check_platform_lock_count_(unsigned int line, unsigned int expected, BOOL clear)
+{
+    unsigned int i, relock, count = 0;
+    DWORD queue;
+    HRESULT hr;
+
+    for (;;)
+    {
+        if (FAILED(hr = MFAllocateWorkQueue(&queue)))
+            break;
+        MFUnlockWorkQueue(queue);
+
+        hr = MFUnlockPlatform();
+        if (FAILED(hr))
+            break;
+        ++count;
+    }
+
+    relock = count;
+    if (clear)
+        relock = min(relock, 1);
+
+    for (i = 0; i < relock; ++i)
+        MFLockPlatform();
+
+    todo_wine_if(clear)
+    ok_(__FILE__, line)(count == expected, "Unexpected lock count %u.\n", count);
+}
+
 struct d3d9_surface_readback
 {
     IDirect3DSurface9 *surface, *readback_surface;
@@ -1664,6 +1695,14 @@ static void test_source_resolver(void)

IMFAsyncCallback_Release(&callback->IMFAsyncCallback_iface);
     IMFAsyncCallback_Release(&callback2->IMFAsyncCallback_iface);
+
+    /* TODO: Wine leaks some async results. */
+    Sleep(100);
+    hr = MFStartup(MF_VERSION, MFSTARTUP_FULL);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    check_and_clear_platform_lock_count(1);
+    hr = MFShutdown();
+    ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
 }

static void init_functions(void)
@@ -3834,10 +3873,7 @@ static void test_startup(void)
     hr = MFStartup(MF_VERSION, MFSTARTUP_FULL);
     ok(hr == S_OK, "Failed to start up, hr %#lx.\n", hr);

-    hr = MFAllocateWorkQueue(&queue);
-    ok(hr == S_OK, "Failed to allocate a queue, hr %#lx.\n", hr);
-    hr = MFUnlockWorkQueue(queue);
-    ok(hr == S_OK, "Failed to unlock the queue, hr %#lx.\n", hr);
+    check_platform_lock_count(1);

hr = MFShutdown();
     ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
@@ -3852,10 +3888,7 @@ static void test_startup(void)
     hr = MFStartup(MF_VERSION, MFSTARTUP_FULL);
     ok(hr == S_OK, "Failed to start up, hr %#lx.\n", hr);

-    hr = MFAllocateWorkQueue(&queue);
-    ok(hr == S_OK, "Failed to allocate a queue, hr %#lx.\n", hr);
-    hr = MFUnlockWorkQueue(queue);
-    ok(hr == S_OK, "Failed to unlock the queue, hr %#lx.\n", hr);
+    check_platform_lock_count(1);

hr = MFShutdown();
     ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
@@ -3864,10 +3897,7 @@ static void test_startup(void)
     hr = MFStartup(MF_VERSION, MFSTARTUP_FULL);
     ok(hr == S_OK, "Failed to start up, hr %#lx.\n", hr);

-    hr = MFAllocateWorkQueue(&queue);
-    ok(hr == S_OK, "Failed to allocate a queue, hr %#lx.\n", hr);
-    hr = MFUnlockWorkQueue(queue);
-    ok(hr == S_OK, "Failed to unlock the queue, hr %#lx.\n", hr);
+    check_platform_lock_count(1);

/* Unlocking implies shutdown. */
     hr = MFUnlockPlatform();
@@ -3879,10 +3909,7 @@ static void test_startup(void)
     hr = MFLockPlatform();
     ok(hr == S_OK, "Failed to lock, %#lx.\n", hr);

-    hr = MFAllocateWorkQueue(&queue);
-    ok(hr == S_OK, "Failed to allocate a queue, hr %#lx.\n", hr);
-    hr = MFUnlockWorkQueue(queue);
-    ok(hr == S_OK, "Failed to unlock the queue, hr %#lx.\n", hr);
+    check_platform_lock_count(1);

hr = MFShutdown();
     ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
@@ -13328,5 +13355,9 @@ START_TEST(mfplat)
     test_MFCreatePathFromURL();
     test_2dbuffer_copy();

+    MFStartup(MF_VERSION, MFSTARTUP_FULL);
+    check_platform_lock_count(1);
+    MFShutdown();
+
     CoUninitialize();
 }