Re: [PATCH 0/1] MR3930: d3d10/tests: Add some tests for D3D10.1 blend state in effects.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3d10_1/tests/d3d10_1.c:
> - ok(desc.DestBlendAlpha == D3D10_BLEND_ZERO, "Unexpected value %d.\n", desc.DestBlendAlpha);
> - ok(desc.BlendOpAlpha == D3D10_BLEND_OP_ADD, "Unexpected value %d.\n", desc.BlendOpAlpha);
> - ok(desc.RenderTargetWriteMask[0] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[0]);
> - ok(desc.RenderTargetWriteMask[1] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[1]);
> - ok(desc.RenderTargetWriteMask[2] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[2]);
> - ok(desc.RenderTargetWriteMask[3] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[3]);
> - ok(desc.RenderTargetWriteMask[4] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[4]);
> - ok(desc.RenderTargetWriteMask[5] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[5]);
> - ok(desc.RenderTargetWriteMask[6] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[6]);
> - ok(desc.RenderTargetWriteMask[7] == D3D10_COLOR_WRITE_ENABLE_ALL, "Unexpected value %d.\n", desc.RenderTargetWriteMask[7]);
> -
> - hr = blend->lpVtbl->GetBlendState(blend, 0, &bs);
> - ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
> -
> - ID3D10BlendState_GetDesc(bs, &desc);
> - ok(desc.SrcBlend == D3D10_BLEND_ZERO, "Unexpected value %d.\n", desc.SrcBlend);

There are no surprises here but I'd add some checks for the first two fields:

```suggestion:-1+0
    ID3D10BlendState_GetDesc(bs, &desc);
    ok(!desc.AlphaToCoverageEnable, "Unexpected value %#x.\n", desc.AlphaToCoverageEnable);
    for (i = 0; i < ARRAY_SIZE(desc.BlendEnable); ++i)
        ok(desc.BlendEnable[i], "Unexpected value %#x.\n", desc.BlendEnable[i]);
    ok(desc.SrcBlend == D3D10_BLEND_ZERO, "Unexpected value %u.\n", desc.SrcBlend);
```