Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
if (!stream_sink->type) return MF_E_NOT_INITIALIZED;
- IMFMediaType_AddRef((*type = stream_sink->type));
- return S_OK;
- hr = MFCreateMediaType(&type_copy);
- if (FAILED(hr))
return hr;
- hr = IMFMediaType_CopyAllItems(stream_sink->type, (IMFAttributes*)type_copy);
- if (FAILED(hr))
IMFMediaType_Release(type_copy);
- else
*type = type_copy;
```suggestion:-7+0 if (FAILED(hr = MFCreateMediaType(&type_copy))) return hr; if (FAILED(hr = IMFMediaType_CopyAllItems(stream_sink->type, (IMFAttributes*)type_copy))) IMFMediaType_Release(type_copy); else *type = type_copy; ```
Nit: lets save some lines.