On Mon Feb 27 14:35:27 2023 +0000, Jacek Caban wrote:
While patch splitting is generally very much appreciated, introducing (temporary) dead code in the process is discouraged in Wine. An alternative way to split is to introduce those helpers together with a code that uses it, but keep it as a very simple pthread wrappers. Then, in a next commit, you could implement additional robustness checks.
I have updated this MR with a variation of your suggestion: 1. Use pthread directly in the (first) commit that needs locking 2. Introduce and use wrappers.
I'll keep the no (temp) dead code policy in mind and rework the commits as needed.