Re: [PATCH v28 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/wintypes/propertyset.c:
> - propertyset_IObservableMap_GetRuntimeClassName,
> - propertyset_IObservableMap_GetTrustLevel,
> - /* IObservableMap<HSTRING, IInspectable*> */
> - propertyset_IObservableMap_add_MapChanged,
> - propertyset_IObservableMap_remove_MapChanged,
>
> +};
> -
>
> +DEFINE_IINSPECTABLE( propertyset_IMap, IMap_HSTRING_IInspectable, struct propertyset,
> -
>                 IPropertySet_iface );
> -
>
> +static HRESULT STDMETHODCALLTYPE propertyset_Lookup( IMap_HSTRING_IInspectable *iface,
> -
>                                                 HSTRING key,
> -
>                                                 IInspectable **value )
>
> +{
> - FIXME( "(%p, %s, %p) stub!\n", iface, debugstr_hstring( key ), value );
> - *value = NULL;

Do you have to set *value to NULL now? If not, you can return E_NOTIMPL and don't touch the value pointer. It's the same for other stubs, for example, propertyset_get_size(). If you want to set it to some value, you might want to check the pointer not being NULL first.