Re: [PATCH 4/7] bcrypt: Add support for exporting DH keys.

[Dmitry Timoshkov]

Hans Leidekker  wrote:
> +static NTSTATUS key_export_dh_public( struct key *key, UCHAR *buf, ULONG len, ULONG *ret_len )
> +{
> - BCRYPT_DH_KEY_BLOB *dh_blob = (BCRYPT_DH_KEY_BLOB *)buf;
> - ULONG size = key->u.a.bitlen / 8;
> - gnutls_dh_params_t params;
> - gnutls_datum_t p, g, y, x = {0};
> - UCHAR *dst;
> - int ret = GNUTLS_E_INVALID_REQUEST;

Initialization of 'ret' seems to be unnecessary.
> -
> - if ((ret = pgnutls_dh_params_init( &params )) < 0)
> - {
> -
>    pgnutls_perror( ret );
> -
>    return STATUS_INTERNAL_ERROR;
> - }