Re: [PATCH v12 0/6] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about server/winstation.c:
>          memset( desktop->keystate, 0, sizeof(desktop->keystate) );
>          list_add_tail( &winstation->desktops, &desktop->entry );
>          list_init( &desktop->hotkeys );
> -
>        desktop->shared_mapping = NULL;
> -
>        desktop->shared = NULL;
> -
> -
>        if ((desktop->shared_mapping = create_object_mapping( &desktop->obj, sizeof(*desktop->shared),
> -
>                                                              (void **)&desktop->shared )))
> -
>            memset( (void *)desktop->shared, 0, sizeof(*desktop->shared) );

Note that `create_object_mapping` already "zeroes" the memory for us, so this line isn't strictly required for correctness. However, keeping this line might be a good idea for explicitness.

In either case, a comment might be worth it.