23 Nov
2023
23 Nov
'23
1:22 p.m.
On Thu Nov 23 01:30:54 2023 +0000, Alfred Agrell wrote:
Solved it; had to switch a few tests to todo, hopefully nothing relies on SetReadStreamSamples() not seeking to the start (considering it previously didn't return the expected compressed data, and changing stream format outside stream start being quite implausible, probably a safe assumption). Also applied all relevant code review remarks I could find in 4450. (Probably plenty of remark-worthy stuff I didn't find, though. Especially the art of commit size eludes me, I'm just guessing.)
Did I mention how much I love it when tests fail in CI but not locally?
At least it reproduces on testbot. https://testbot.winehq.org/JobDetails.pl?Key=140242&f101=task.log#k101