Zebediah Figura (@zfigura) commented about dlls/d3d9/tests/utils.h:
HRESULT hr;
- for (i = 0; i < 500; ++i)
- /* Some of the larger loops in test_occlusion_query() can take quite some time on
* software Mesa (i.e., the gitlab CI machines). */
- for (i = 0; i < 1000; ++i) { if ((hr = IDirect3DQuery9_GetData(query, NULL, 0, D3DGETDATA_FLUSH)) == S_OK) break; Sleep(10); }
- if (hr == S_OK)
- {
todo_wine_if (i >= 500)
ok_(file, line)(i < 500, "Query took %u ms to finish.\n", i * 10);
I don't think that a todo_wine makes sense here? It's not like it's invalid behaviour to take a long time to render.
How long does rendering take, in seconds? If it's too long we may as well just get rid of the test (or skip it if the device is a software renderer); it's nice to have but not at the expense of slowing down the test suite.