On Tue Oct 18 12:38:43 2022 +0000, Florian Kübler wrote:
changed this line in version 2 of the diff
Thats actually a very good idea. I applied your suggestions.
Regarding the "always two byte encoding": I would argue its not worth the two saved lines compared to the headache the non-standard leb128 encoding will introduce. I even needed to look up the algorithm and DWARF spec. description again, to see if this is even valid. Seems that we could set the highest significant bit, of the low significant byte and have 0x00 as high significant byte, but still that adds quite of confusion and also is likely to introduce errors in the future when updating the offsets. Right now, I can simply do the encoding using the leb128 python library to be sure to not make errors.