Re: [PATCH 0/8] MR6151: mshtml: window.performance improvements.

[Jacek Caban (＠jacek)]

On Sun Jul 28 19:45:40 2024 +0000, Gabriel Ivăncescu wrote:
> Oh yeah, I forgot there's another interface now (I only had one on
> either jscript or mshtml side with everything to keep it simple).
> BTW, what part of `dispex_builtin_props_to_json` is questionable? The
> fact it's generic? Should I hardcode the props list in each object
> instead, or? I tried to be thorough with tests to show that it's only
> the builtin props (and not functions, but props/accessors) that get
> placed in the JSON object, but if you have any ideas or think I missed
> something please let me know.
> I made it generic to keep it simpler to avoid having to special case
> each object in turn.

Generic is fine, but you shouldn't need to call hooks directly here, we have other helpers.