On Fri Nov 17 16:55:50 2023 +0000, Martin Storsjö wrote:
Oh, right - I failed to set that your original version didn’t set any format attributes in clang/msvc builds, while my suggestion does. How could I overlook that? I guess I didn’t consider that you intentionally wanted to omit the argument from a configuration where it could be supported. Anyway, avoiding such unnecessary warnings probably is good in any case.
Yes, fixing it in standalone vkd3d would be nice as well. I'm not sure which solution would be preferred, vkd3d already uses macros like `PRIx64`, so I their usage could be extended. An easy solution would be disabling those warnings in condigure or skipping format attribute on PE targets in the header and depending on Unix builds to validate formats. Anyway, it's a separated issue, this MR just brings msvc target on pair with mingw.