On Thu Sep 15 20:41:21 2022 +0000, Jacek Caban wrote:
- I'm not sure what you mean, if you suggest not creating the event at
all, that's now what the patch is doing. 2. I'd suggest to know it before using it as an argument. 3. Is there anything depending on it? The alternative would be to change other callers to make Gecko match MSHTML.
Ok so it turns out Gecko does support creating Message or Storage events via CreateEvent, but I still don't see how this is useful at all considering we don't use them? What I really dislike is that in other parts we're not using them at all, so it's not symmetric and doesn't match the behavior, even if it doesn't change the outcome, it's still confusing and pointless.
To be fair, I can improve this by using `event_types[event_info[event_id].type]` for non-gecko events to obtain the "Event" string, so that it matches `create_document_event`. That should be fine, right?
We do need at least a nsevent though, since DOMEvent uses it for generic event functionality. Hence the "Event" type.